Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAP HANA DB Metrics Collector #11

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

SAP HANA DB Metrics Collector #11

wants to merge 3 commits into from

Conversation

K-Padmini
Copy link

SAP HANA DB Metric Collector

We have created a new implementation of Data Collector using OTel based Sensor SDK
for SAP Hana DB metric collection.

liurui-1
liurui-1 reviewed Feb 1, 2024
View reviewed changes
Copy link

@liurui-1 liurui-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this good contribution!
We have some structure change because we will have many new implementations.
We prefer to put each implementation into its own package/directory.
Could you rebase the code from main branch and create your own package/directory for SAP HANA DB?

@K-Padmini
Copy link
Author

Thanks for this good contribution! We have some structure change because we will have many new implementations. We prefer to put each implementation into its own package/directory. Could you rebase the code from main branch and create your own package/directory for SAP HANA DB?

Sure We will do that , since i'm working a release and the feature freeze coming up , would be okay if i add my changes by Monday ?
Sorry for the delay!

@liurui-1
Copy link

liurui-1 commented Feb 4, 2024

Thanks for this good contribution! We have some structure change because we will have many new implementations. We prefer to put each implementation into its own package/directory. Could you rebase the code from main branch and create your own package/directory for SAP HANA DB?

Sure We will do that , since i'm working a release and the feature freeze coming up , would be okay if i add my changes by Monday ? Sorry for the delay!

no problem.

@liurui-1 liurui-1 force-pushed the main branch 4 times, most recently from 74ad347 to 523f04d Compare June 27, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurui-1 liurui-1 liurui-1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-Padmini @liurui-1